Skip to content

chore: dualize Order.Frame more - #44623

Open
plp127 wants to merge 20 commits into
leanprover-community:masterfrom
plp127:aliu/dual-frame
Open

plp127 wants to merge 20 commits into
leanprover-community:masterfrom
plp127:aliu/dual-frame

Conversation

@plp127

@plp127 plp127 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Use to_dual_for to connect Order.Frame.mk and Order.Frame.le_himp_iff with their duals. Also dualize some CompleteDistribLattice declarations.


@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 7, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

PR summary f27cc4ae5e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- CoheytingAlgebra.ofHNot
- CoheytingAlgebra.ofSDiff
- Function.Injective.generalizedCoheytingAlgebra
- OrderDual.instFrame
- OrderDual.instGeneralizedHeytingAlgebra
- OrderDual.instHeytingAlgebra
- Pi.instCoframe
- Pi.instCoheytingAlgebra
- Pi.instGeneralizedCoheytingAlgebra
- Prod.instCoframe
- Prod.instCoheytingAlgebra
- Prod.instGeneralizedCoheytingAlgebra
- le_himp_iff'
- sdiff_le_iff'

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit f27cc4a).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit f27cc4ae5e
Reference commit 35f494609c

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-order Order theory label Oct 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant